Skip to content

feat: add guides list to toolbar v2 w/ eligibility status indicators#846

Merged
thomaswhyyou merged 25 commits into
mainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-6
Feb 13, 2026
Merged

feat: add guides list to toolbar v2 w/ eligibility status indicators#846
thomaswhyyou merged 25 commits into
mainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-6

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026 •
edited
Loading

Description

  • Implements the first set of guide "annotation"s in useInspectGuideClientStore, which is used by the toolbar to surface various guide statuses for debugging purposes.
  • In this PR, we only focus on eligibility statuses (active, archived, targetable statuses)
  • Adds GuidesList to show a list of guides with its eligibility statuses
  • Adds GuidesListDisplaySelect to filter the list based on eligibility statuses
  • Adds GuideHoverCard that shows individual guide's payload from the guide client state store

Screenshots or videos

CleanShot.2026-02-12.at.10.47.26.mp4

@linear
Copy link
Copy Markdown

linear Bot commented Feb 2, 2026

KNO-11142 [SDK] Guide Toolbar v2 poc

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 2, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 13, 2026 1:51am
javascript-nextjs-example Ready Ready Preview, Comment Feb 13, 2026 1:51am
javascript-slack-connect-example Ready Ready Preview, Comment Feb 13, 2026 1:51am
javascript-slack-kit-example Ready Ready Preview, Comment Feb 13, 2026 1:51am

Request Review

This was referenced Feb 2, 2026
Merged
Merged
@thomaswhyyou Graphite App
Copy link
Copy Markdown
Contributor Author

thomaswhyyou commented Feb 2, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@thomaswhyyou thomaswhyyou mentioned this pull request Feb 2, 2026
Merged
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 2, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4a41c9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Feb 2, 2026
Merged
Merged
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from 968d4b2 to ac879d5 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from 89d2bfa to a415e75 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from ac879d5 to 84f9e9e Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from a415e75 to b5369e6 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from 84f9e9e to 0ebc110 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from b5369e6 to 0a38e96 Compare February 3, 2026 19:09
cursor[bot]
cursor Bot reviewed Feb 12, 2026
View reviewed changes
Comment thread packages/react/src/modules/guide/components/Toolbar/V2/useInspectGuideClientStore.ts
Comment thread packages/react/src/modules/guide/components/Toolbar/V2/GuideHoverCard.tsx
cursor[bot]
cursor Bot reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread packages/react/src/modules/guide/components/Toolbar/V2/V2.tsx
return {
debug: state.debug,
};
return <GuideRow key={guide.key} guide={guide} orderIndex={idx} />;
Copy link
Copy Markdown

@cursor cursor Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtered guide list shows non-sequential row numbering

Low Severity

In GuidesList, the idx from guides.map() is passed directly as orderIndex to GuideRow. When displayOption is "all-eligible", ineligible guides return null but idx still reflects the original array position. This creates visible gaps in the row numbering (e.g., #1, #3, #5 instead of #1, #2, #3). Using .filter() before .map() would produce sequential numbering for the visible rows.

Fix in Cursor Fix in Web

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 46.80851% with 150 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.34%. Comparing base (1b09589) to head (4a41c9b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 13.25% 72 Missing ⚠️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 10.63% 42 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 20.83% 19 Missing ⚠️
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 15.00% 17 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   67.97%   67.34%   -0.64%     
==========================================
  Files         199      203       +4     
  Lines        8194     8461     +267     
  Branches     1075     1101      +26     
==========================================
+ Hits         5570     5698     +128     
- Misses       2599     2738     +139     
  Partials       25       25
Files with missing lines Coverage Δ
packages/client/src/clients/guide/index.ts 100.00% <ø> (ø)
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 100.00% <100.00%> (ø)
...act/src/modules/guide/components/Toolbar/shared.ts 100.00% <100.00%> (ø)
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 15.00% <15.00%> (ø)
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 15.90% <20.83%> (+0.52%) ⬆️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 10.63% <10.63%> (ø)
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 13.25% <13.25%> (ø)

This was referenced Feb 18, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@connorlindsey connorlindsey connorlindsey approved these changes

@MikeCarbone MikeCarbone Awaiting requested review from MikeCarbone MikeCarbone is a code owner automatically assigned from knocklabs/product

@andy-knock andy-knock Awaiting requested review from andy-knock andy-knock is a code owner automatically assigned from knocklabs/product

@cjbell cjbell Awaiting requested review from cjbell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomaswhyyou @connorlindsey